[META] - Converted EuiCardGraphic to TS + tests
#1751
Conversation
|
Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually? |
| @@ -3,7 +3,7 @@ | |||
| /// <reference path="./button/index.d.ts" /> | |||
| /// <reference path="./call_out/index.d.ts" /> | |||
| /// <reference path="./code/index.d.ts" /> | |||
| /// <reference path="./combo_box/index.d.ts" /> | |||
There was a problem hiding this comment.
combo_box was referenced twice here
|
All comments welcome |
src/components/card/card_graphic.tsx
Outdated
| color = 'blue', | ||
| }) => { | ||
| // Set the svg gradient colors | ||
| // @ts-ignore |
There was a problem hiding this comment.
ts complains here for posible undefined
There was a problem hiding this comment.
better to add a ! before the .start, .end, and .path accesses -
const graphicStartColor: string = graphicColorsToCodes.find(
w => w.color === color
)!.start;
The ! assures Typescript the object does exist, while not suppressing any other potential errors with ts-ignore.
|
I've updated my PR to resolve conflicts |
src/components/card/card_graphic.tsx
Outdated
| color = 'blue', | ||
| }) => { | ||
| // Set the svg gradient colors | ||
| // @ts-ignore |
There was a problem hiding this comment.
better to add a ! before the .start, .end, and .path accesses -
const graphicStartColor: string = graphicColorsToCodes.find(
w => w.color === color
)!.start;
The ! assures Typescript the object does exist, while not suppressing any other potential errors with ts-ignore.
|
Thanks for putting this together! |
|
Cool, I didn't knew that trick. I will update the PR. Thanx. |
|
jenkins test this |
Summary
As per #1557, I converted the
EuiCardGraphicto TS.Checklist